Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev에서는 browserable api 활성화 및 api 필드 수정 #67

Merged
merged 2 commits into from
Apr 29, 2023
Merged

dev에서는 browserable api 활성화 및 api 필드 수정 #67

merged 2 commits into from
Apr 29, 2023

Conversation

golony6449
Copy link
Member

목표

  • 개발의 용이성을 위해 def browserable api 기능을 활성화 합니다.
  • 겸사겸사 후원사 정보조회 api를 수정합니다.

작업 내용

  • browserable api 관련 설정을 settings-prod.py로 이동
  • serializer 수정

유의 사항

  • 리뷰어는 PyConKR-2023을 지정해주세요.
  • 작업한 내용을 상세하게 작성해주세요.

@golony6449 golony6449 requested a review from a team as a code owner April 27, 2023 15:35
@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

hanlee55
hanlee55 approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@hanlee55 hanlee55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제가 browserable 비활성화 설정을 전역 설정에다가 넣어버렸군요! 감사합니다!

@golony6449 golony6449 merged commit ffce52a into pythonkr:devdev Apr 29, 2023
@golony6449 golony6449 deleted the feature/golony/deactivate-browsable-api branch April 29, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanlee55 hanlee55 hanlee55 approved these changes

@oleveloper oleveloper oleveloper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@golony6449 @hanlee55 @oleveloper