Skip to content

fix ts fe test error. #3619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 26, 2025
Merged

fix ts fe test error. #3619

merged 5 commits into from
Jun 26, 2025

Conversation

lanluo-nvidia
Copy link
Collaborator

@lanluo-nvidia lanluo-nvidia commented Jun 25, 2025

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)
flashinfer = pytest.importorskip("flashinfer")
this way once pyest is run, it gives the following:
SKIPPED [1] automatic_plugin/test_flashinfer_rmsnorm.py:3: could not import 'flashinfer': No module named 'flashinfer'
with error code, which will make the CI show as red.

change to:
@unittest.skipIf(not importlib.util.find_spec("flashinfer"), "flashinfer not installed")
so that pytest will skip and show as green

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@lanluo-nvidia lanluo-nvidia requested a review from peri044 June 25, 2025 22:14
@github-actions github-actions bot added the component: tests Issues re: Tests label Jun 25, 2025
@github-actions github-actions bot requested a review from narendasan June 25, 2025 22:14
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the component: build system Issues re: Build system label Jun 26, 2025
@lanluo-nvidia lanluo-nvidia merged commit ab9e309 into main Jun 26, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: build system Issues re: Build system component: tests Issues re: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants