Closed the perf gap of resnet and enabled refit #3629
+167
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: conversion
narendasan
reviewed
Jun 27, 2025
| @@ -90,7 +91,18 @@ def construct_refit_mapping_from_weight_name_map( | |||
| ) -> dict[Any, Any]: | |||
| engine_weight_map = {} | |||
| for engine_weight_name, (sd_weight_name, np_weight_type) in weight_name_map.items(): | |||
| if sd_weight_name not in state_dict: | |||
| if engine_weight_name.split(" ")[-1] in ["SCALE", "SHIFT"]: | |||
There was a problem hiding this comment.
We should abstract this imo. Like if there are any weight types that require constant folding in converter this should be associated with the converter. Then the refit system will just iterate through all these constant fold operations. Ideally the converter can use the same implementation
There was a problem hiding this comment.
Currently BN is the only one. Do you think we should have a constant_fold function and have refit and conversion call that function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: