Skip to content

Add Differentiable Physics: Mass-Spring System example #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jun 25, 2025
Merged

Add Differentiable Physics: Mass-Spring System example #1359

merged 13 commits into from
Jun 25, 2025

Conversation

abhitorch81
Copy link
Contributor

Re-submitting PR #1332 from my corporate GitHub account (abhitorch81).

This PR includes:

  • A simple differentiable mass-spring system using PyTorch
  • Clarified explanation of initial and target particle positions
  • Simulation defined in 2D with gravity vector [0, -9.8]
  • High-resolution PNG output showing final vs. target positions
  • Formal reference to Learning to Simulate Complex Physics with Graph Networks

Reviewer feedback from @dvrogozh on the previous PR has been fully addressed.

AbhiLegend and others added 12 commits April 29, 2025 18:28
@AbhiLegend
Add Differentiable Physics: Mass-Spring System example
7d3d2a1
@AbhiLegend
Add differentiable_physics to run_all() in test script
39a0c8e
@AbhiLegend
Resolved merge conflict and integrated differentiable_physics test
3d01b48
@AbhiLegend
Add visualization and update training code in mass_spring.py
77c8abc
@AbhiLegend
Finalize differentiable_physics with visualization and CI integration
84072d5
@AbhiLegend
Finalize differentiable_physics with visualization and CI integration
8a7cf5e
@AbhiLegend
Finalize differentiable_physics with the updates
f20fa20
@AbhiLegend
Update requirements.txt for differentiable_physics
e14251f
@AbhiLegend
Update run_python_examples.sh to test differentiable_physics in CI
96e04f1
@AbhiLegend
Add mass spring example and update requirements
35b0afa
@AbhiLegend
Add mass spring example and update requirements
f1a806e
@abhitorch81
Updated README and visualization from corporate ID (abhitorch81)
b4c7bcf
@abhitorch81 abhitorch81 requested a review from msaroufim as a code owner June 25, 2025 07:53
@netlify Netlify
Copy link

netlify bot commented Jun 25, 2025 •
edited
Loading

✅ Deploy Preview for pytorch-examples-preview canceled.

Name Link
🔨 Latest commit 42dacb5
🔍 Latest deploy log https://app.netlify.com/projects/pytorch-examples-preview/deploys/685bb16a5e26a50008ed5372

@abhitorch81
Copy link
Contributor Author

abhitorch81 commented Jun 25, 2025 •
edited
Loading

@dvrogozh Can you review the PR converted from personal id to corporate id ,continuing from #1332

@msaroufim msaroufim merged commit 7c35995 into pytorch:main Jun 25, 2025
8 checks passed
msaroufim added a commit that referenced this pull request Jun 25, 2025
@msaroufim
Revert "Add Differentiable Physics: Mass-Spring System example (#1359)"
ac6b73e 
This reverts commit 7c35995.
@msaroufim msaroufim mentioned this pull request Jun 25, 2025
Merged
msaroufim added a commit that referenced this pull request Jun 25, 2025
@msaroufim
Revert "Add Differentiable Physics: Mass-Spring System example" (#1360)
8d408d2 
Revert "Add Differentiable Physics: Mass-Spring System example (#1359)"

This reverts commit 7c35995.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msaroufim msaroufim Awaiting requested review from msaroufim msaroufim is a code owner

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abhitorch81 @msaroufim @facebook-github-bot @AbhiLegend