Update PAL override docs for new APIs #11747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11747
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New FailuresAs of commit 34cf951 with merge base 7b39a0c ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
GregoryComer
added
the
release notes: none
Comment on lines
61
to
64
| ET_UNUSED bool registration_result = runtime::register_pal(build_pal()); | ||
| ``` |
There was a problem hiding this comment.
Is this how you do static initialization? It should be a static variable right?
There was a problem hiding this comment.
@larryliu0820 I updated the example code to be slightly more clear. The original snippet is inside an anonymous namespace, which serves the same purpose of translation-unit scoping for the variable. But it is a global constructor in the same way. I've included the anonymous namespace in the snippet so that this is more clear.
larryliu0820
approved these changes
Jun 18, 2025
hinriksnaer
pushed a commit
to hinriksnaer/executorch
that referenced
this pull request
Jun 26, 2025
### Summary Update PAL docs in using-executorch-runtime-integration.md to describe the new PAL override mechanism introduced in pytorch#10675. I've left the docs in for the weak symbol override mechanism, as well, though I've recommended use of the runtime APIs. ### Test plan I built the docs locally to validate form and content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update PAL docs in using-executorch-runtime-integration.md to describe the new PAL override mechanism introduced in #10675. I've left the docs in for the weak symbol override mechanism, as well, though I've recommended use of the runtime APIs.
Test plan
I built the docs locally to validate form and content.