-
Notifications
You must be signed in to change notification settings - Fork 608
Move LlmConfig to extension/llm #11872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11872
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit d865320 with merge base a627be6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
44b5eac
to
ffc8453
Compare
718304a
to
aabb6fa
Compare
@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
bc9756c
to
9a8282d
Compare
@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was exported from Phabricator. Differential Revision: D77338897 |
Summary: Moves `LlmConfig` from `examples/models/llama/config` to `extension/llm/export/config` Pull Request resolved: #11872 Differential Revision: D77338897 Pulled By: jackzhxng
9a8282d
to
c086f42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this is just a mechanical move? i.e. no functional change otherwise?
Also I assume moving this in extensions/llm is been through a review of sorts?
Summary: Moves `LlmConfig` from `examples/models/llama/config` to `extension/llm/export/config` Pull Request resolved: #11872 Differential Revision: D77338897 Pulled By: jackzhxng
This pull request was exported from Phabricator. Differential Revision: D77338897 |
c086f42
to
d865320
Compare
Moves
LlmConfig
fromexamples/models/llama/config
toextension/llm/export/config