-
Notifications
You must be signed in to change notification settings - Fork 607
Move transformer base definition to extension/llm #11917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11917
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 47 New FailuresAs of commit f65b648 with merge base 77a7ace ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
9d77d2e
to
04b91d6
Compare
718304a
to
aabb6fa
Compare
aabb6fa
to
7212a18
Compare
7212a18
to
bc9756c
Compare
bc9756c
to
9a8282d
Compare
9a8282d
to
c086f42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it mainly mechanical move? I see bunch of CI failures, also added trunk tag to make sure we don't regress silently on other jobs.
@@ -0,0 +1,308 @@ | |||
# @lint-ignore-every LICENSELINT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use git mv
to preserve the history better? I saw the import error message update, perhaps that's why you didn't do it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try, I just forgot to do git mv
this time
c086f42
to
d865320
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's not make the extension/llm/modeling/text_decoder/decoder_model.py move. There are too many examples and meta specific stuff there... let's keep it in examples
Why did you not move llama_transformer.py to extension inside? |
No description provided.