Skip to content

[EE/BE][ET][Portable] Move scalar_to utils to scalar_utils.h #11980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

manuelcandales
Copy link
Contributor

@manuelcandales manuelcandales commented Jun 25, 2025

@manuelcandales manuelcandales requested a review from swolchok as a code owner June 25, 2025 19:36
Copy link

pytorch-bot bot commented Jun 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11980

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b27ed23 with merge base 89bdd1d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 25, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75962656

@manuelcandales manuelcandales added the release notes: none Do not include this in the release notes label Jun 26, 2025
@manuelcandales manuelcandales merged commit 8142c96 into gh/manuelcandales/113/base Jun 26, 2025
98 of 101 checks passed
@manuelcandales manuelcandales deleted the gh/manuelcandales/113/head branch June 26, 2025 04:14
manuelcandales added a commit that referenced this pull request Jun 26, 2025
manuelcandales added a commit that referenced this pull request Jun 26, 2025
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* __->__ #11982
* #11980

- Tests for bad alpha values: add.Tensor & add.Scalar
- Fixes alpha handling in portable/optimized op_add kernels
- Eliminates usage of ET_SWITCH_SCALAR_OBJ_TYPES in optimized op_add
kernel

Differential Revision:
[D77325770](https://our.internmc.facebook.com/intern/diff/D77325770/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants