Skip to content

Arm backend: Add atan decomposition pass and test #11998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

tbergkvist
Copy link
Contributor

@tbergkvist tbergkvist commented Jun 26, 2025

Decomposes atan using Padé approximation/lookup table for MI/BI case.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Decomposes atan using Padé approximation/lookup table for MI/BI case.

Change-Id: Ie38695481d61fb81c31cfd18b7ff2ca1e33ce609
Signed-off-by: Teo Bergkvist <[email protected]>
@tbergkvist tbergkvist requested a review from digantdesai as a code owner June 26, 2025 12:24
Copy link

pytorch-bot bot commented Jun 26, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11998

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Cancelled Job

As of commit b428bba with merge base ecb85ce (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 26, 2025
@tbergkvist
Copy link
Contributor Author

tbergkvist commented Jun 26, 2025

@pytorchbot label "release notes: arm"

Copy link

pytorch-bot bot commented Jun 26, 2025

Didn't find following labels among repository labels: release,notes:,arm

@tbergkvist
Copy link
Contributor Author

@pytorchbot label "partner: arm"

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Jun 26, 2025
@tbergkvist
Copy link
Contributor Author

@pytorchbot label "release notes: arm"

@pytorch-bot pytorch-bot bot added the release notes: arm Changes to the ARM backend delegate label Jun 26, 2025
@tbergkvist
Copy link
Contributor Author

@pytorchbot label "ciflow/trunk"

Copy link

pytorch-bot bot commented Jun 26, 2025

To add these label(s) (ciflow/trunk) to the PR, please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

Copy link

pytorch-bot bot commented Jun 26, 2025

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@tbergkvist
Copy link
Contributor Author

@pytorchbot label "ciflow/trunk"

@zingo zingo merged commit ba9254a into pytorch:main Jun 26, 2025
194 of 200 checks passed
hinriksnaer pushed a commit to hinriksnaer/executorch that referenced this pull request Jun 26, 2025
Decomposes atan using Padé approximation/lookup table for MI/BI case.

Signed-off-by: Teo Bergkvist <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants