Add gtest macros and matchers for Result<T> and Error. #12038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsharma35
requested review from
JacobSzwejbka,
lucylq and
swolchok
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12038
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a2a7476 with merge base 268806c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77409312 |
hsharma35
force-pushed
the
export-D77409312
branch
from
144422b to
225ab71
Compare
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Jun 27, 2025
Summary: Adds matcher support for Result and Error types, similar to absl::Status. Differential Revision: D77409312
|
This pull request was exported from Phabricator. Differential Revision: D77409312 |
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Jun 27, 2025
Summary: Adds matcher support for Result and Error types, similar to absl::Status. Differential Revision: D77409312
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Jun 27, 2025
Summary: Adds matcher support for Result and Error types, similar to absl::Status. Differential Revision: D77409312
hsharma35
force-pushed
the
export-D77409312
branch
from
225ab71 to
7151468
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77409312 |
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Jun 27, 2025
Summary: Adds matcher support for Result and Error types, similar to absl::Status. Differential Revision: D77409312
hsharma35
force-pushed
the
export-D77409312
branch
from
7151468 to
bcb62f6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77409312 |
hsharma35
force-pushed
the
export-D77409312
branch
from
bcb62f6 to
7f45bf0
Compare
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Jun 28, 2025
Summary: Adds matcher support for Result and Error types, similar to absl::Status. Differential Revision: D77409312
Summary: Pull Request resolved: pytorch#12038 Adds matcher support for Result and Error types, similar to absl::Status. Differential Revision: D77409312
|
This pull request was exported from Phabricator. Differential Revision: D77409312 |
hsharma35
force-pushed
the
export-D77409312
branch
from
7f45bf0 to
a2a7476
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Adds matcher support for Result and Error types, similar to absl::Status.
Differential Revision: D77409312