Skip to content

Bump pinned PT commit to 20250625 and mirror torch/standalone to ExecuTorch #12068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025

Conversation

pytorchbot
Copy link
Collaborator

This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #11968 by @swolchok
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/swolchok/475/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/swolchok/475/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/swolchok/475/orig
@diff-train-skip-merge

Copy link

pytorch-bot bot commented Jun 27, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12068

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 15 Pending, 3 Unrelated Failures

As of commit 056b7b9 with merge base b74c68d (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 27, 2025
@swolchok
Copy link
Contributor

swolchok commented Jun 27, 2025

looking at test failures:

  • unittest-editable / macos is a known flake
  • huggingface-transformers tests are all failing because .ci/docker/ci_commit_pins/optimum-executorch.txt is missing; don't understand why they're not failing on trunk
  • unittest-nxp-neutron is failing because backends/nxp/run_unittests.sh is missing, ditto don't understand why it's not failing on trunk
  • lintrunner is failing with the same issues as on the original PR, looking at the failures I still really don't see why they would be changed as EdgeOpOverload is not coming from upstream PyTorch

@swolchok
Copy link
Contributor

going to rebase the branch and hope this stuff goes away, I think

@swolchok swolchok force-pushed the gh/swolchok/475/orig branch from e9bc51f to 08203b4 Compare June 27, 2025 20:41
@swolchok
Copy link
Contributor

huggingface-transformers failure went away

@swolchok
Copy link
Contributor

lintrunner continues to not repro locally. ring-attention is known flaky. rebasing, merging, and monitoring for new failures on HUD.

…uTorch

Pull Request resolved: #11968

Current pin bump D76909683 / #11791 has CoreML issues; sending another bump just in case it happens to be less red.

Differential Revision: [D77308624](https://our.internmc.facebook.com/intern/diff/D77308624/)
ghstack-source-id: 292982785
@swolchok swolchok force-pushed the gh/swolchok/475/orig branch from 08203b4 to 056b7b9 Compare June 27, 2025 21:13
Copy link
Contributor

@swolchok swolchok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging bot PR

@swolchok
Copy link
Contributor

closer inspection of the lintrunner failure reveals that it seems to be plausibly caused by a pytorch pin update, and it's hard to get the pinned PT version to get properly used locally

@swolchok swolchok added the release notes: none Do not include this in the release notes label Jun 27, 2025
@swolchok swolchok merged commit 2a2d757 into main Jun 27, 2025
200 of 204 checks passed
@swolchok swolchok deleted the gh/swolchok/475/orig branch June 27, 2025 22:10
swolchok added a commit that referenced this pull request Jun 27, 2025
I mistakenly thought lint issues on #12068 were inaccurate. Fast following with fix.


ghstack-source-id: bad7fa8
ghstack-comment-id: 3014481657
Pull-Request-resolved: #12075
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants