Skip to content

Fix model selection #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Fix model selection #43

wants to merge 12 commits into from

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Jun 28, 2025

There is a bug in the script where I wrongly used models variable as both the input list of target models and to de-dup the list of selected models.

Testing

https://github.com/pytorch/pytorch-integration-testing/actions/runs/15940471919/job/44967831823

python .github/scripts/generate_vllm_benchmark_matrix.py --benchmark-configs-dir vllm-benchmarks/benchmarks --models "meta-llama/Llama-4-Maverick-17B-128E-Instruct-FP8" --gpus h100

returns only one job now

::set-output name=benchmark_matrix::{'include': [{'runner': 'linux.aws.h100.8', 'models': 'meta-llama/llama-4-maverick-17b-128e-instruct-fp8'}]}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants