Skip to content

Rename 'wf' to 'samples' in AudioEncoder #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 29, 2025

Conversation

Dan-Flores
Copy link
Contributor

@Dan-Flores Dan-Flores commented May 27, 2025

This PR renames variables in the C++ code and Python from 'wf' to 'samples' for clarity.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label May 27, 2025
@NicolasHug
Copy link
Member

Thanks for the PR @Dan-Flores !

There seem to be 2 remaining failing job:

FAILED test/test_encoders.py::TestAudioEncoder::test_num_channels[to_file-2-2] - RuntimeError: Could not open input file: /tmp/pytest-of-root/pytest-0/test_num_channels_to_file_2_2_0/output.mp3 Invalid data found when processing input

I see this one on main as well, so it's probably not related to this PR. I'll try to figure out what's going on separately.

There's a build error on the macos job:

/Users/ec2-user/runner/_work/torchcodec/torchcodec/pytorch/torchcodec/src/torchcodec/_core/./../../../src/torchcodec/_core/Encoder.h:54:7: error: private field 'desiredNumChannels_' is not used [-Werror,-Wunused-private-field]
  int desiredNumChannels_ = -1;

I think you just need to remove the correspdoning line, which probably is an artifact of a previous merge.

After that this is good to go!

@Dan-Flores Dan-Flores marked this pull request as ready for review May 28, 2025 18:53
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Dan-Flores !

@Dan-Flores Dan-Flores merged commit 6d3ad1a into pytorch:main May 29, 2025
61 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants