Skip to content

Commit

Permalink
Merge bitcoin#18879: valgrind: remove outdated suppressions
Browse files Browse the repository at this point in the history
d7120f7 valgrind : remove duplicate BCLog::Logger suppression (fanquake)
708e3c7 valgrind: remove rest_blockhash_by_height suppression (fanquake)

Pull request description:

  bitcoin@708e3c7: `Suppress rest_blockhash_by_height` should no longer be needed after bitcoin#18785.

  bitcoin@d7120f7 : Removes a duplicate `Suppress BCLog::Logger::StartLogging()` suppression that was added in bitcoin#17770.

ACKs for top commit:
  MarcoFalke:
    ACK d7120f7
  practicalswift:
    ACK d7120f7 -- patch looks correct and valgrind Travis job is happy

Tree-SHA512: 45f5b9fa64bf83cada3cd9ad33c245f660376d5b29f51a2531d83133940090df945f5ef26c5847d6ec024ffab9528d55573c5cf9ca5e73795f9abfc971b3d29b
  • Loading branch information
MarcoFalke committed May 5, 2020
2 parents ec79b5f + d7120f7 commit 52ce396
Showing 1 changed file with 0 additions and 13 deletions.
13 changes: 0 additions & 13 deletions contrib/valgrind.supp
Original file line number Diff line number Diff line change
Expand Up @@ -184,16 +184,3 @@
...
fun:_ZN5BCLog6Logger12StartLoggingEv
}
{
Suppress BCLog::Logger::StartLogging() still reachable memory warning
Memcheck:Leak
match-leak-kinds: reachable
fun:malloc
...
fun:_ZN5BCLog6Logger12StartLoggingEv
}
{
Suppress rest_blockhash_by_height Conditional jump or move depends on uninitialised value(s)
Memcheck:Cond
fun:_ZL24rest_blockhash_by_heightP11HTTPRequestRKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE
}

0 comments on commit 52ce396

Please sign in to comment.