Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow compiling QCxMS with GCC #47

Merged
merged 3 commits into from
Feb 4, 2022
Merged

Allow compiling QCxMS with GCC #47

merged 3 commits into from
Feb 4, 2022

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Nov 15, 2021

Fixes some issues which are specific to GCC

  • build checked with GCC 11.1.0
  • enable workflow for GCC 11 and GCC 9 on Ubuntu 20.04
  • use error stop to get non-zero exit codes in case of failures
  • fix a wrong call to system rather than qccall in iniqm
  • longer seed required for random number generator in GFortran runtime

Probably needs one additional manual check regarding performance and correctness against an Intel compiled binary before merging.

@awvwgk awvwgk mentioned this pull request Feb 3, 2022
Closed
@awvwgk awvwgk linked an issue Feb 3, 2022 that may be closed by this pull request
Failed to build with GCC #48
Closed
@JayTheDog JayTheDog merged commit f51bdf4 into qcxms:main Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to build with GCC
2 participants
@awvwgk @JayTheDog