Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: The github platform supports AI capabilities #472

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

wwcchh0123
Copy link
Contributor

@wwcchh0123 wwcchh0123 commented Dec 2, 2024

check list

  • pr review comment support interactiving with reviewbot AI
  • issue comment support interactiving with reviewbot AI
  • The results of linter are explained in detail by reviewbot AI

effect

the first point

image

the second point

image

the third point see

image

Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for reviewbot-x canceled.

Name Link
🔨 Latest commit 189a149
🔍 Latest deploy log https://app.netlify.com/sites/reviewbot-x/deploys/674ff58e81b3320008215e0f

@wwcchh0123 wwcchh0123 force-pushed the llm1128 branch 3 times, most recently from 8faac49 to 900fe30 Compare December 3, 2024 11:18
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 4.97238% with 172 lines in your changes missing coverage. Please review.

Project coverage is 23.71%. Comparing base (c1e9cfd) to head (189a149).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
server.go 0.00% 96 Missing ⚠️
main.go 0.00% 25 Missing ⚠️
internal/llm/llm.go 16.00% 21 Missing ⚠️
internal/llm/ollama.go 0.00% 16 Missing ⚠️
internal/llm/openapi.go 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #472      +/-   ##
==========================================
- Coverage   25.01%   23.71%   -1.30%     
==========================================
  Files          33       36       +3     
  Lines        4633     4920     +287     
==========================================
+ Hits         1159     1167       +8     
- Misses       3335     3613     +278     
- Partials      139      140       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wwcchh0123 wwcchh0123 force-pushed the llm1128 branch 3 times, most recently from d896154 to 537a340 Compare December 3, 2024 11:37
server.go Outdated Show resolved Hide resolved
main.go Show resolved Hide resolved
@wwcchh0123 wwcchh0123 force-pushed the llm1128 branch 3 times, most recently from a6e8873 to 25b53d7 Compare December 4, 2024 04:08
@@ -31,6 +31,7 @@ import (
"github.com/google/go-github/v57/github"
"github.com/prometheus/client_golang/prometheus/promhttp"
"github.com/qiniu/reviewbot/config"
"github.com/qiniu/reviewbot/internal/llm"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golangci-lint] reported by reviewbot🐮
File is not gci-ed with --skip-generated -s standard -s default (gci)

@@ -140,6 +145,11 @@ func (a *Agent) ApplyTypedMessageByIssueReferences(ctx context.Context, lintResu
}
}
if !processed {
resp, err := llm.QueryForReference(ctx, a.ModelClient, output.Message)
if err != nil {
log.Errorf("failed to query LLM server: %v", err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该需要continue

@@ -126,7 +127,7 @@ func TestApplyTypedMessageByIssueReferences(t *testing.T) {
expectedOutput: map[string][]LinterOutput{
"file4.go": {
{
Message: "regular lint message without issue reference",
Message: "regular lint message without issue reference" + fmt.Sprintf(ReferenceFooter, ""),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

空的情况下,还有这个Footer有点奇怪

@CarlJi CarlJi merged commit e361936 into qiniu:master Dec 4, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants