-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: The github platform supports AI capabilities #472
Conversation
✅ Deploy Preview for reviewbot-x canceled.
|
8faac49
to
900fe30
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #472 +/- ##
==========================================
- Coverage 25.01% 23.71% -1.30%
==========================================
Files 33 36 +3
Lines 4633 4920 +287
==========================================
+ Hits 1159 1167 +8
- Misses 3335 3613 +278
- Partials 139 140 +1 ☔ View full report in Codecov by Sentry. |
d896154
to
537a340
Compare
a6e8873
to
25b53d7
Compare
@@ -31,6 +31,7 @@ import ( | |||
"github.com/google/go-github/v57/github" | |||
"github.com/prometheus/client_golang/prometheus/promhttp" | |||
"github.com/qiniu/reviewbot/config" | |||
"github.com/qiniu/reviewbot/internal/llm" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[golangci-lint] reported by reviewbot🐮
File is not gci
-ed with --skip-generated -s standard -s default (gci)
@@ -140,6 +145,11 @@ func (a *Agent) ApplyTypedMessageByIssueReferences(ctx context.Context, lintResu | |||
} | |||
} | |||
if !processed { | |||
resp, err := llm.QueryForReference(ctx, a.ModelClient, output.Message) | |||
if err != nil { | |||
log.Errorf("failed to query LLM server: %v", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
应该需要continue
@@ -126,7 +127,7 @@ func TestApplyTypedMessageByIssueReferences(t *testing.T) { | |||
expectedOutput: map[string][]LinterOutput{ | |||
"file4.go": { | |||
{ | |||
Message: "regular lint message without issue reference", | |||
Message: "regular lint message without issue reference" + fmt.Sprintf(ReferenceFooter, ""), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
空的情况下,还有这个Footer有点奇怪
check list
effect
the first point
the second point
the third point see