bug fix: bit map for each bit

qiutian2018 · Feb 8, 2023 · 85ce687 · 85ce687
1 parent fe20c6c
commit 85ce687
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/datastruct/bitmap/bitmap.go b/datastruct/bitmap/bitmap.go
@@ -74,10 +74,13 @@ func (b *BitMap) ForEachBit(begin int64, end int64, cb Callback) {
 			}
 			bitOffset++
 			offset++
+			if offset >= end {
+				break
+			}
 		}
 		byteIndex++
 		bitOffset = 0
-		if end > 0 && offset == end {
+		if end > 0 && offset >= end {
 			break
 		}
 	}

diff --git a/datastruct/bitmap/bitmap_test.go b/datastruct/bitmap/bitmap_test.go
@@ -67,7 +67,7 @@ func TestForEachBit(t *testing.T) {
 	}
 	expectOffset := int64(100)
 	count := 0
-	bm.ForEachBit(100, 200, func(offset int64, val byte) bool {
+	bm.ForEachBit(100, 201, func(offset int64, val byte) bool {
 		if offset != expectOffset {
 			t.Error("wrong offset")
 		}
@@ -78,7 +78,7 @@ func TestForEachBit(t *testing.T) {
 		count++
 		return true
 	})
-	if count != 100 {
+	if count != 101 {
 		t.Error("wrong count")
 	}
 	bm = New()