feat(autocomplete): optimize some const of autocomplete (element-plus…

…#2593) * feat(autocomplete): optimize some const of autocomplete * feat(autocomplete): optimize some const of autocomplete
qq10137383 · Jul 21, 2021 · 6a7b9a4 · 6a7b9a4
1 parent 0bf673d
commit 6a7b9a4
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/packages/autocomplete/src/index.vue b/packages/autocomplete/src/index.vue
@@ -301,13 +301,13 @@ export default defineComponent({
       const suggestionList = suggestion.querySelectorAll('.el-autocomplete-suggestion__list li')
       const highlightItem = suggestionList[index]
       const scrollTop = suggestion.scrollTop
-      const offsetTop = highlightItem.offsetTop
+      const { offsetTop, scrollHeight } = highlightItem
 
-      if (offsetTop + highlightItem.scrollHeight > (scrollTop + suggestion.clientHeight)) {
-        suggestion.scrollTop += highlightItem.scrollHeight
+      if (offsetTop + scrollHeight > (scrollTop + suggestion.clientHeight)) {
+        suggestion.scrollTop += scrollHeight
       }
       if (offsetTop < scrollTop) {
-        suggestion.scrollTop -= highlightItem.scrollHeight
+        suggestion.scrollTop -= scrollHeight
       }
       highlightedIndex.value = index
       inputRef.value.inputOrTextarea.setAttribute('aria-activedescendant', `${id.value}-item-${highlightedIndex.value}`)