Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 2024.8 FanEntityFeature TURN_ON and TURN_OFF #95

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

cloudrainstar
Copy link
Contributor

This is required for the Heat Exchanger to be turned on and off in 2025.1, even though the blog mentions the deprecation will happen in 2025.2.

This is required for the Heat Exchanger to be turned on and off in 2025.1, even though the blog mentions the deprecation will happen in 2025.2.
Copy link
Owner

@qqaatw qqaatw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution. Did you test it out locally?

custom_components/jcihitachi_tw/fan.py Show resolved Hide resolved
@cloudrainstar
Copy link
Contributor Author

LGTM, thank you for your contribution. Did you test it out locally?

Yessir, made the changes yesterday locally to have my Heat Exchanger on/off working again before submitting this PR!

@qqaatw qqaatw merged commit 0e65725 into qqaatw:master Jan 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants