Reformat link src logic

qridwan · Jul 4, 2023 · d29b899 · d29b899
1 parent 453e471
commit d29b899
Showing 1 changed file with 11 additions and 22 deletions.
diff --git a/src/app/components/Resume/ResumePDF/ResumePDFProfile.tsx b/src/app/components/Resume/ResumePDF/ResumePDFProfile.tsx
@@ -56,34 +56,23 @@ export const ResumePDFProfile = ({
           const Wrapper = ({ children }: { children: React.ReactNode }) => {
             if (!shouldUseLinkWrapper) return <>{children}</>;
 
-            let urlSrc = "";
-
+            let src = "";
             switch (key) {
-              case "email":
-                urlSrc = `mailto:${value}`;
-                break;
-
-              case "phone":
-                urlSrc = `tel:${value.replace(/[^\d+]/g, "")}`;
+              case "email": {
+                src = `mailto:${value}`;
                 break;
-
-              case "url":
-                let removalCases = ["http://", "https://"];
-                let http_protocol = "https://";
-
-                removalCases.forEach((item) => {
-                  if (value.startsWith(item)) {
-                    value = value.substring(item.length - 1, value.length - 1);
-                    http_protocol = item;
-                  }
-                });
-
-                urlSrc = `${http_protocol}${value}`;
+              }
+              case "phone": {
+                src = `tel:${value.replace(/[^\d+]/g, "")}`; // Keep only + and digits
                 break;
+              }
+              default: {
+                src = value.startsWith("http") ? value : `https://${value}`;
+              }
             }
 
             return (
-              <ResumePDFLink src={urlSrc} isPDF={isPDF}>
+              <ResumePDFLink src={src} isPDF={isPDF}>
                 {children}
               </ResumePDFLink>
             );