Revert "VCSBaseEditorParameterWidget::mapSetting cope with 0 pointer"

This reverts commit b5ce5e9 because the check already happened two lines before. Change-Id: Ic230fe767c22dc4747a4ceecedd68fc09c99267b Reviewed-by: Orgad Shaneh <[email protected]> Reviewed-by: Tobias Hunger <[email protected]>
qtdevs · Mar 9, 2017 · f4c0c78 · f4c0c78
1 parent 0e4b233
commit f4c0c78
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/plugins/vcsbase/vcsbaseeditorconfig.cpp b/src/plugins/vcsbase/vcsbaseeditorconfig.cpp
@@ -194,7 +194,7 @@ void VcsBaseEditorConfig::mapSetting(QComboBox *comboBox, QString *setting)
         d->m_settingMapping.insert(comboBox, Internal::SettingMappingData(setting));
         if (setting) {
             comboBox->blockSignals(true);
-            const int itemIndex = setting ? comboBox->findData(*setting) : -1;
+            const int itemIndex = comboBox->findData(*setting);
             if (itemIndex != -1)
                 comboBox->setCurrentIndex(itemIndex);
             comboBox->blockSignals(false);