BLD: Github Actions #363
Merged
BLD: Github Actions #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What does that do? |
richafrank
reviewed
Mar 10, 2020
| fail-fast: false | ||
| matrix: | ||
| os: [ubuntu-latest] | ||
| python-version: [2.7, 3.5, 3.7, 3.8] |
There was a problem hiding this comment.
Is this python-version required if we're explicit below in include?
There was a problem hiding this comment.
Yes - the include is on the version specified I believe. https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#example-including-configurations-in-a-matrix-build. My understanding is that you're augmenting and existing build.
added 2 commits
March 10, 2020 13:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR transitions us from Travis to Github actions. It also does the work to fix flake8 issues and get tests passing on python 2.7 and python 3.5.
Tests still fail in python 3.7/3.8 with newer pandas/numpy/etc.
Future work involves