Restore aimet-torch-cpu variant in PR job #3761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kyunggeun Lee <[email protected]>
Signed-off-by: Kyunggeun Lee <[email protected]>
Signed-off-by: Kyunggeun Lee <[email protected]>
quic-kyunggeu
requested review from
quic-akhobare,
quic-hitameht,
quic-emironov and
quic-mtuttle
quic-mtuttle
approved these changes
Jan 30, 2025
quic-hitameht
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In #3741, @quic-emironov has made somewhat-major behavioral changes as follows:
@pytest.mark.cuda), and aimet-*-cpu variants only run non-cuda test cases.These behavioral differences between the old PR jobs (in Jenkins) and the new PR jobs (in GitHub Action) is making us hesitant to completely replace Jenkins with GitHub Action.
Main Changes
Restored the old behaviors where aimet-*-gpu tests both cuda and non-cuda test cases so that everyone feels safer about transitioning our PR jobs' infrastructure from Jenkins to GitHub Action completely.