Workflow Browser

[nl0]

A dedicated space for workflows

Checklist

• configurable visibility?
• Changelog entry (skip if change is not significant to end users, e.g. docs only)

[codecov]

Codecov Report

Attention: Patch coverage is 8.00000% with 184 lines in your changes missing coverage. Please review.

Project coverage is 38.83%. Comparing base (ac4d63d) to head (e5785b5).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
catalog/app/containers/Bucket/Workflows/List.tsx	0.00%	52 Missing and 1 partial ⚠️
catalog/app/containers/Bucket/Workflows/index.tsx	0.00%	45 Missing and 5 partials ⚠️
catalog/app/containers/Bucket/Workflows/Detail.tsx	0.00%	48 Missing and 1 partial ⚠️
catalog/app/containers/Bucket/Workflows/Layout.tsx	0.00%	12 Missing ⚠️
catalog/app/containers/Bucket/Workflows/search.ts	0.00%	6 Missing ⚠️
catalog/app/containers/Search/model.ts	28.57%	5 Missing ⚠️
catalog/app/constants/routes.ts	50.00%	2 Missing ⚠️
catalog/app/containers/Bucket/BucketNav.tsx	0.00%	2 Missing ⚠️
...et/Workflows/gql/WorkflowPackageCount.generated.ts	0.00%	2 Missing ⚠️
...Bucket/Workflows/gql/WorkflowPackages.generated.ts	0.00%	2 Missing ⚠️
... and 1 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4360      +/-   ##
==========================================
- Coverage   39.02%   38.83%   -0.19%     
==========================================
  Files         786      793       +7     
  Lines       34791    34977     +186     
  Branches     5505     5544      +39     
==========================================
+ Hits        13576    13583       +7     
- Misses      20032    20204     +172     
- Partials     1183     1190       +7     

Flag	Coverage Δ
api-python	91.41% <ø> (ø)
catalog	17.84% <8.00%> (-0.11%)	⬇️
lambda	91.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[greptile-apps]

PR Summary

Added a comprehensive workflow browser feature to the catalog UI, enabling users to explore and manage workflows within buckets.

• Added new routes /b/:bucket/workflows and /b/:bucket/workflows/:slug in catalog/app/constants/routes.ts for workflow navigation
• Implemented responsive workflow list view with grid layout and package count indicators in catalog/app/containers/Bucket/Workflows/List.tsx
• Added workflow detail view showing metadata, schema links and associated packages in catalog/app/containers/Bucket/Workflows/Detail.tsx
• Added GraphQL queries WorkflowPackageCount and WorkflowPackages for fetching workflow-related package data
• Integrated workflow browser into bucket navigation with a dedicated "Workflows" tab in BucketNav.tsx

_{16 file(s) reviewed, 15 comment(s)
Edit PR Review Bot Settings | Greptile}

[fiskus]

I like, how this feature makes separate sections of the Quilt linked together, and the app feels more holistic.

It looks like workflow page should have the same UI blocks (packages) as Packages tab:

• that way same concepts (packages) have same UI representation
• grid stretches awkwardly when there is a long meta string

[drernie]

The only hard request is to make this configurable via the usual Catalog UI configuration file. My current assumption is that this will be on by default, though that may change based on feedback at BioIT World.

[nl0]

added configurable visibility and adjusted the ui to use outlined surfaces instead of elevated ones

[nl0]

It looks like workflow page should have the same UI blocks (packages) as Packages tab:

* that way same concepts (packages) have same UI representation

they are mostly the same, the only difference being absence of the sparkline and the metadata,
so these are more like abbreviated versions.
the adjusted search ui uses the same representation btw, and i'm going to update the package listing page
to have the cards look similar (sometime soonish).

* grid stretches awkwardly when there is a long meta string

well, somewhat, yeah, but it doesn't seem that bad

[fiskus]

It's difficult to read text with font-weight: 300. I suggest to use 400

[nl0]

It's difficult to read text with font-weight: 300. I suggest to use 400

idk, seems quite readable to me. 400 is regular weight, and i specifically wanted to make it lighter

addressed