Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search streamline #4362

Draft
wants to merge 30 commits into
base: master
Choose a base branch
from
Draft

Search streamline #4362

wants to merge 30 commits into from

Conversation

nl0
Copy link
Member

@nl0 nl0 commented Mar 25, 2025

Description

TODO

  • Unit tests
  • Automated tests (e.g. Preflight)
  • Confirm that this change meets security best practices and does not violate the security model
  • Documentation
    • run optipng on any new PNGs
    • Python: Run build.py for new docstrings
    • JavaScript: basic explanation and screenshot of new features
    • Markdown somewhere in docs/**/*.md that explains the feature to end users (said .md files should be linked from SUMMARY.md so they appear on https://docs.quiltdata.com)
    • Markdown docs for developers
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 4.98442% with 305 lines in your changes missing coverage. Please review.

Project coverage is 38.72%. Comparing base (ac4d63d) to head (3096f82).

Files with missing lines Patch % Lines
catalog/app/containers/Search/Hit.tsx 0.00% 98 Missing and 1 partial ⚠️
catalog/app/containers/Bucket/Workflows/List.tsx 0.00% 52 Missing and 1 partial ⚠️
catalog/app/containers/Bucket/Workflows/index.tsx 0.00% 45 Missing and 5 partials ⚠️
catalog/app/containers/Bucket/Workflows/Detail.tsx 0.00% 48 Missing and 1 partial ⚠️
catalog/app/containers/Bucket/Workflows/Layout.tsx 0.00% 12 Missing ⚠️
catalog/app/containers/Search/Search.tsx 0.00% 12 Missing ⚠️
catalog/app/containers/Bucket/Workflows/search.ts 0.00% 6 Missing ⚠️
catalog/app/containers/Search/Results.tsx 0.00% 5 Missing ⚠️
catalog/app/containers/Search/model.ts 28.57% 5 Missing ⚠️
catalog/app/components/JsonDisplay/JsonDisplay.tsx 0.00% 4 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4362      +/-   ##
==========================================
- Coverage   39.02%   38.72%   -0.31%     
==========================================
  Files         786      794       +8     
  Lines       34791    35080     +289     
  Branches     5505     5573      +68     
==========================================
+ Hits        13576    13583       +7     
- Misses      20032    20306     +274     
- Partials     1183     1191       +8     
Flag Coverage Δ
api-python 91.41% <ø> (ø)
catalog 17.77% <4.98%> (-0.18%) ⬇️
lambda 91.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

* workflows-tab:
  fix tests
  style: update workflow UI components with outlined variant and spacing adjustments
  feat: add workflows tab toggle in bucket preferences
  Bump amazonlinux from 2023.6.20250303.0 to 2023.6.20250317.2 in /catalog (#4364)
  Bump amazonlinux from 2023.6.20250303.0 to 2023.6.20250317.2 in /s3-proxy (#4365)
  OpenLanding cleaning up (#4361)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant