$.fn.removeAttr: ensuring a collection containing non-element objects…

… doesn’t cause an error to be thrown
r-aamir · Jan 3, 2020 · 2230646 · 2230646
1 parent 5f1c9c9
commit 2230646
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/attributes/remove_attr.ts b/src/attributes/remove_attr.ts
@@ -13,6 +13,8 @@ fn.removeAttr = function ( this: Cash, attr: string ) {
 
   return this.each ( ( i, ele ) => {
 
+    if ( !isElement ( ele ) ) return;
+
     each ( attrs, ( i, a ) => {
 
       ele.removeAttribute ( a );

diff --git a/test/modules/attributes.js b/test/modules/attributes.js
@@ -346,6 +346,16 @@ describe ( 'Attributes', { beforeEach: getFixtureInit ( fixture ) }, function ()
 
     });
 
+    it ( 'supports collections containing non-elements objects', function ( t ) {
+
+      var ele = $(document.createTextNode ( '.css' ));
+
+      ele.removeAttr ( 'foo' );
+
+      t.pass ();
+
+    });
+
   });
 
   describe ( '$.fn.removeClass', function ( it ) {