$.fn.hide|show|toggle: ensuring a collection containing non-element o…

…bjects doesn’t case an error to be thrown
r-aamir · Dec 30, 2019 · dc8e956 · dc8e956
1 parent f82e06e
commit dc8e956
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/effects/toggle.ts b/src/effects/toggle.ts
@@ -13,6 +13,8 @@ fn.toggle = function ( this: Cash, force?: boolean ) {
 
   return this.each ( ( i, ele ) => {
 
+    if ( !isElement ( ele ) ) return;
+
     const show = isUndefined ( force ) ? isHidden ( ele ) : force;
 
     if ( show ) {

diff --git a/test/modules/effects.js b/test/modules/effects.js
@@ -134,6 +134,16 @@ describe ( 'Effects', { beforeEach: getFixtureInit ( fixture ) }, function () {
 
     });
 
+    it ( 'supports collections containing non-elements objects', function ( t ) {
+
+      var eles = $('.shown');
+
+      eles.toggle ().toggle ().toggle ().toggle ();
+
+      t.pass ();
+
+    });
+
   });
 
 });