Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nanodbc: backport TVP patches #898

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

detule
Copy link
Collaborator

@detule detule commented Mar 1, 2025

Hi:

This catches up our vendored nanodbc lib to upstream in terms of TVP functionality. Not part of this PR:

  • Upstream TVP functionality that is in review.
  • Updates to 'odbc' API to take advantage of this feature.

On the last two I will prepare a new PR; the diff on this one alone ended up being large enough that I thought breaking it out might make sense in terms of being able to better attribute any changes in existing behavior ( hopefully none! ).

Compare upstream: nanodbc/nanodbc#259

upstream: nanodbc/nanodbc#259

nanodbc: missing convert wide to *

nanodbc: fixup sqldescribeparam
@detule detule requested a review from simonpcouch March 1, 2025 19:29
Copy link
Collaborator

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the upstream ref. Looks good—thank you!

// 888 Y8P 888 "888 "888 888 Y8b 888 888 888888 888 Y88o88P 888
// 888 " 888 Y88b d88P Y88b d88P Y88b.Y8b88P 888 888 Y888P 888
// 888 888 "Y8888P" "Y8888P" "Y888888" 88888888 888 Y8P 888
// Y8b
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎨

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants