WIP: Feature/docker setup #3

pinboro · 2019-03-07T06:38:54Z

Introduce a simple Docker / docker-compose setup for local environment.

r3c

npm protection is a good thing and shouldn't be worked around IMO, configure script is expected to work fine without the need for root account.

pinboro · 2019-03-07T09:04:41Z

I am considering running the script with Apache user.

…ll for deval

pinboro · 2019-03-07T14:42:33Z

@r3c Updated.

r3c

Thanks! I'll checkout your change locally to try it, as I'm clearly missing knowledge about Docker :)

.gitignore

INSTALL.md

setup/docker/initdb.php

docker-compose.yml

setup/docker/entrypoint.sh

r3c

I got stuck when trying to run yAronet using this Docker setup because no locale was configured. I believe something like this in the Dockerfile should do the trick:

apt-get install -y locales # can be added to your existing apt-get command
sed -ri 's/# (en_US.UTF-8 UTF-8)/\1/' /etc/locale.gen
locale-gen

There are other stuff missing but they're bugs in my code rather than related to this review, so I'll quickly fix them :) (RewriteBase is incorrect in .htaccess files, configuration of static directory seems invalid, and website logo doesn't display properly)

pinboro · 2019-03-09T14:36:26Z

Oh, yeah, I was sticking to 'C' locale, which you need to input on the install.php page. But let's adjust to your default one.

RewriteBase needs at least one argument, which is "/" in my case. Could you update the default to be "/" please?

r3c · 2019-03-09T16:53:35Z

Yes you're right about RewriteBase being broken, let me fix that :)

pinboro · 2019-03-10T01:36:28Z

Default locale changed to en_US.UTF-8

pinboro · 2019-03-10T02:11:15Z

Added a retry loop for db connection to not fail hard when db container is not ready yet.

r3c · 2019-03-10T09:56:51Z

Almost there! It's mostly working now, the only remaining issue I can't get around for now is parser.php not being generated. When I run sudo docker-compose up command, following message appears in the log:

{ [Error: EACCES: permission denied, open 'src/parser.php']
  errno: -13,
  code: 'EACCES',
  syscall: 'open',
  path: 'src/parser.php' }

I don't know if it's related to root user or something else and will continue to investigate. Thanks for all your new changes!

[update] Grant permissions on setup/module to www-data from the entrypoint.sh script does the trick, although I'm not sure this is a really clean way of dealing with the issue as it's visible from host point of view.

Now this is done I'm having errors when web host tries to mount, saying it cannot resolve the DB hostname 😕

pinboro · 2019-03-10T10:26:31Z

Can you share the entire log?

pinboro · 2019-03-10T10:28:30Z

Also, this is good to do to be able to run docker command with being root.

https://docs.docker.com/install/linux/linux-postinstall/#manage-docker-as-a-non-root-user

r3c · 2019-03-10T10:32:45Z

That's not the same: your link describes how to configure Docker to avoid entering sudo docker on every command. What I was referring to is the chown call made on source files to switch them to www-data user, which I understand is needed for Apache to serve development files that are supposedly owned by current user instead. However this makes them impossible to update from host system anyway, which is not a desirable effect. I'll search how to avoid this in a further commit.

Here is the log, seems something is going wrong with the SQL setup, I'll try to see what exactly:

Creating network "yaronet_default" with the default driver
Creating yaronet_db_1 ... 
Creating yaronet_db_1 ... done
Creating yaronet_web_1 ... 
Creating yaronet_web_1 ... done
Attaching to yaronet_db_1, yaronet_web_1
db_1   | Initializing database
db_1   | 2019-03-10T10:32:01.699366Z 0 [Warning] TIMESTAMP with implicit DEFAULT value is deprecated. Please use --explicit_defaults_for_timestamp server option (see documentation for more details).
db_1   | 2019-03-10T10:32:01.704379Z 0 [ERROR] --initialize specified but the data directory has files in it. Aborting.
db_1   | 2019-03-10T10:32:01.704398Z 0 [ERROR] Aborting
db_1   | 
yaronet_db_1 exited with code 1
web_1  | audited 4435 packages in 6.823s
web_1  | found 1 low severity vulnerability
web_1  |   run `npm audit fix` to fix them, or `npm audit` for details
web_1  | built src/parser.php
web_1  | audited 2 packages in 0.855s
web_1  | found 0 vulnerabilities
web_1  | 
web_1  | 
web_1  | Warning: mysqli::__construct(): php_network_getaddresses: getaddrinfo failed: No address associated with hostname in /yaronet/setup/docker/initdb.php on line 12
web_1  | 
web_1  | Warning: mysqli::__construct(): (HY000/2002): php_network_getaddresses: getaddrinfo failed: No address associated with hostname in /yaronet/setup/docker/initdb.php on line 12
web_1  | 
web_1  | MySQL Connection Error: (2002) php_network_getaddresses: getaddrinfo failed: No address associated with hostname
web_1  | Retrying...(9)
web_1  | 
web_1  | Warning: mysqli::__construct(): php_network_getaddresses: getaddrinfo failed: No address associated with hostname in /yaronet/setup/docker/initdb.php on line 12
web_1  | 
web_1  | Warning: mysqli::__construct(): (HY000/2002): php_network_getaddresses: getaddrinfo failed: No address associated with hostname in /yaronet/setup/docker/initdb.php on line 12
web_1  | 
web_1  | MySQL Connection Error: (2002) php_network_getaddresses: getaddrinfo failed: No address associated with hostname
web_1  | Retrying...(8)
web_1  | 
web_1  | Warning: mysqli::__construct(): php_network_getaddresses: getaddrinfo failed: No address associated with hostname in /yaronet/setup/docker/initdb.php on line 12
web_1  | 
web_1  | Warning: mysqli::__construct(): (HY000/2002): php_network_getaddresses: getaddrinfo failed: No address associated with hostname in /yaronet/setup/docker/initdb.php on line 12
web_1  | 
web_1  | MySQL Connection Error: (2002) php_network_getaddresses: getaddrinfo failed: No address associated with hostname
web_1  | Retrying...(7)
web_1  | 
web_1  | Warning: mysqli::__construct(): php_network_getaddresses: getaddrinfo failed: No address associated with hostname in /yaronet/setup/docker/initdb.php on line 12
web_1  | 
web_1  | Warning: mysqli::__construct(): (HY000/2002): php_network_getaddresses: getaddrinfo failed: No address associated with hostname in /yaronet/setup/docker/initdb.php on line 12
web_1  | 
web_1  | MySQL Connection Error: (2002) php_network_getaddresses: getaddrinfo failed: No address associated with hostname
web_1  | Retrying...(6)
web_1  | 
web_1  | Warning: mysqli::__construct(): php_network_getaddresses: getaddrinfo failed: No address associated with hostname in /yaronet/setup/docker/initdb.php on line 12
web_1  | 
web_1  | Warning: mysqli::__construct(): (HY000/2002): php_network_getaddresses: getaddrinfo failed: No address associated with hostname in /yaronet/setup/docker/initdb.php on line 12
web_1  | 
web_1  | MySQL Connection Error: (2002) php_network_getaddresses: getaddrinfo failed: No address associated with hostname
web_1  | Retrying...(5)
web_1  | 
web_1  | Warning: mysqli::__construct(): php_network_getaddresses: getaddrinfo failed: No address associated with hostname in /yaronet/setup/docker/initdb.php on line 12
web_1  | 
web_1  | Warning: mysqli::__construct(): (HY000/2002): php_network_getaddresses: getaddrinfo failed: No address associated with hostname in /yaronet/setup/docker/initdb.php on line 12
web_1  | 
web_1  | MySQL Connection Error: (2002) php_network_getaddresses: getaddrinfo failed: No address associated with hostname
web_1  | Retrying...(4)
web_1  | 
web_1  | Warning: mysqli::__construct(): php_network_getaddresses: getaddrinfo failed: No address associated with hostname in /yaronet/setup/docker/initdb.php on line 12
web_1  | 
web_1  | Warning: mysqli::__construct(): (HY000/2002): php_network_getaddresses: getaddrinfo failed: No address associated with hostname in /yaronet/setup/docker/initdb.php on line 12
web_1  | 
web_1  | MySQL Connection Error: (2002) php_network_getaddresses: getaddrinfo failed: No address associated with hostname
web_1  | Retrying...(3)
web_1  | 
web_1  | Warning: mysqli::__construct(): php_network_getaddresses: getaddrinfo failed: No address associated with hostname in /yaronet/setup/docker/initdb.php on line 12
web_1  | 
web_1  | Warning: mysqli::__construct(): (HY000/2002): php_network_getaddresses: getaddrinfo failed: No address associated with hostname in /yaronet/setup/docker/initdb.php on line 12
web_1  | 
web_1  | MySQL Connection Error: (2002) php_network_getaddresses: getaddrinfo failed: No address associated with hostname
web_1  | Retrying...(2)
web_1  | 
web_1  | Warning: mysqli::__construct(): php_network_getaddresses: getaddrinfo failed: No address associated with hostname in /yaronet/setup/docker/initdb.php on line 12
web_1  | 
web_1  | Warning: mysqli::__construct(): (HY000/2002): php_network_getaddresses: getaddrinfo failed: No address associated with hostname in /yaronet/setup/docker/initdb.php on line 12
web_1  | 
web_1  | MySQL Connection Error: (2002) php_network_getaddresses: getaddrinfo failed: No address associated with hostname
web_1  | Retrying...(1)
web_1  | 
web_1  | Warning: mysqli::__construct(): php_network_getaddresses: getaddrinfo failed: No address associated with hostname in /yaronet/setup/docker/initdb.php on line 12
web_1  | 
web_1  | Warning: mysqli::__construct(): (HY000/2002): php_network_getaddresses: getaddrinfo failed: No address associated with hostname in /yaronet/setup/docker/initdb.php on line 12
web_1  | 
web_1  | MySQL Connection Error: (2002) php_network_getaddresses: getaddrinfo failed: No address associated with hostname
yaronet_web_1 exited with code 1```

pinboro · 2019-03-10T10:34:25Z

I know it is not the same, just sharing for removing you some pain:)

r3c · 2019-03-10T10:35:17Z

Ah OK :)

[edit] Removed the "tmp" folder, now it's booting. Let's wait and see :)

r3c · 2019-03-10T10:39:38Z

Working! Here is the only change I applied to your latest patch:

$ git diff
diff --git a/setup/docker/entrypoint.sh b/setup/docker/entrypoint.sh
index bb47fc3..f0aaf9b 100755
--- a/setup/docker/entrypoint.sh
+++ b/setup/docker/entrypoint.sh
@@ -10,7 +10,7 @@ ln -s ${APP_HOME}/src /var/www/html
 
 # Install dependencies
 cd ${APP_HOME}
-chown -R www-data:www-data src /var/www
+chown -R www-data:www-data setup/module src /var/www
 npm install
 su -s setup/configure.sh www-data

How do you feel about applying this change and merging your patch into master? Seems a good baseline :)

pinboro · 2019-03-10T10:42:36Z

I am good!
Let’s push a first baseline.

There are improvement points around the entrypoint, and permissions, but they are not critical for a local environment.

r3c · 2019-03-10T10:50:04Z

Done! Thanks a lot for your contribution and help! 👍

pinboro added 7 commits March 7, 2019 15:28

Add Docker initial files

1d456ad

Script to test DB connection and initialize DB schema

9bbd2df

Ignore tmp folder used for local environment DB data

75e4be9

Update documentation for Docker setup

58d4a2f

Allow deval npm install to run with root privileges

3f21943

Fix wrong path

c77cc86

Refactoring and source cleanup.

a9294bc

r3c requested changes Mar 7, 2019

View reviewed changes

Run configure.sh as apache user and remove --unsafe-perm on npm insta…

b583288

…ll for deval

r3c requested changes Mar 8, 2019

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

INSTALL.md Show resolved Hide resolved

INSTALL.md Show resolved Hide resolved

setup/docker/initdb.php Show resolved Hide resolved

Clearer syntax for tmp folder ignore rule

519e9d5

r3c reviewed Mar 9, 2019

View reviewed changes

docker-compose.yml Show resolved Hide resolved

setup/docker/entrypoint.sh Show resolved Hide resolved

r3c reviewed Mar 9, 2019

View reviewed changes

set default locale to en_US.UTF-8

d2af993

pinboro added 3 commits March 10, 2019 11:06

Ensure DB is ready when trying to initialize it

6e57478

Use yaronet user instead of root for DB connection

5c57ed4

Provide working configuration values for docker-compose

8b78965

r3c merged commit fe368d1 into r3c:master Mar 10, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Feature/docker setup #3

WIP: Feature/docker setup #3

pinboro commented Mar 7, 2019

r3c left a comment

pinboro commented Mar 7, 2019

pinboro commented Mar 7, 2019

r3c left a comment

r3c left a comment •

edited

Loading

pinboro commented Mar 9, 2019

r3c commented Mar 9, 2019

pinboro commented Mar 10, 2019

pinboro commented Mar 10, 2019

r3c commented Mar 10, 2019 •

edited

Loading

pinboro commented Mar 10, 2019

pinboro commented Mar 10, 2019

r3c commented Mar 10, 2019 •

edited

Loading

pinboro commented Mar 10, 2019

r3c commented Mar 10, 2019 •

edited

Loading

r3c commented Mar 10, 2019

pinboro commented Mar 10, 2019

r3c commented Mar 10, 2019

WIP: Feature/docker setup #3

WIP: Feature/docker setup #3

Conversation

pinboro commented Mar 7, 2019

r3c left a comment

Choose a reason for hiding this comment

pinboro commented Mar 7, 2019

pinboro commented Mar 7, 2019

r3c left a comment

Choose a reason for hiding this comment

r3c left a comment • edited Loading

Choose a reason for hiding this comment

pinboro commented Mar 9, 2019

r3c commented Mar 9, 2019

pinboro commented Mar 10, 2019

pinboro commented Mar 10, 2019

r3c commented Mar 10, 2019 • edited Loading

pinboro commented Mar 10, 2019

pinboro commented Mar 10, 2019

r3c commented Mar 10, 2019 • edited Loading

pinboro commented Mar 10, 2019

r3c commented Mar 10, 2019 • edited Loading

r3c commented Mar 10, 2019

pinboro commented Mar 10, 2019

r3c commented Mar 10, 2019

r3c left a comment •

edited

Loading

r3c commented Mar 10, 2019 •

edited

Loading

r3c commented Mar 10, 2019 •

edited

Loading

r3c commented Mar 10, 2019 •

edited

Loading