set DEBIAN_FRONTEND and allow it to be passed into sudo context by …

…default

fixes issues with any application that needs to use the debian frontend to interact with a user (such as used when restarting systemd services on reboot and accepting EULAs)

fixes wps-office install which requires ttf-mscorefonts-installer which asks to sign a EULA and would previously show a non-functional purple/pink screen (dialog)

etc/runonce-entries

@@ -403,4 +403,11 @@ runonce <<"EOF"
   fi
 EOF
 
+#include DEBIAN_FRONTEND variable in sudo default environment if set
+runonce <<"EOF"
+  sudo_popup sh -c "cat > /etc/sudoers.d/debian_frontend << _EOF_
+Defaults      env_keep += DEBIAN_FRONTEND
+_EOF_"
+EOF
+
 true

gui

@@ -76,7 +76,7 @@ generate_logo &
 
 #install dependencies
 runonce <<"EOF"
-  dependencies='yad curl wget aria2 lsb-release software-properties-common apt-utils apt-transport-https gnupg imagemagick bc librsvg2-bin locales shellcheck git wmctrl xdotool x11-utils rsync unzip debsums'
+  dependencies='yad curl wget aria2 lsb-release software-properties-common apt-utils apt-transport-https gnupg imagemagick bc librsvg2-bin locales shellcheck git wmctrl xdotool x11-utils rsync unzip debsums libgtk3-perl'
   # Install dependencies if necessary
   if ! dpkg -s $dependencies >/dev/null 2>&1; then
     sudo_popup apt install $dependencies -y -f --no-install-recommends

install

@@ -23,7 +23,7 @@ fi
 sudo apt update || error "The command 'sudo apt update' failed. Before Pi-Apps will work, you must fix your apt package-management system."
 
 #install dependencies
-dependencies='yad curl wget aria2 lsb-release software-properties-common apt-utils apt-transport-https gnupg imagemagick bc librsvg2-bin locales shellcheck git wmctrl xdotool x11-utils rsync unzip debsums'
+dependencies='yad curl wget aria2 lsb-release software-properties-common apt-utils apt-transport-https gnupg imagemagick bc librsvg2-bin locales shellcheck git wmctrl xdotool x11-utils rsync unzip debsums libgtk3-perl'
 
 if ! dpkg -s $dependencies &>/dev/null ;then
   sudo apt install $dependencies -y -f --no-install-recommends || error "Pi-Apps dependencies failed to install and so the Pi-Apps install has been aborted. Before Pi-Apps can be installed you must solve any errors above."

manage

@@ -689,6 +689,11 @@ elif [ "$1" == 'install' ] || [ "$1" == 'uninstall' ];then
   else
     script_input=""
   fi
+  #always overwrite DEBIAN_FRONTEND with gnome
+  #dialog and readline are not functional due to the logfile pipe
+  #noninteractive cannot be used as many debian scripts set their default as option as no (when the user needs to click yet) or do not allow for noninteractive use
+  #this will fallback to another option if the gnome dialog cannot be launched
+  export DEBIAN_FRONTEND=gnome
   nice "${appscript[@]}" "$script_input" &> >(tee -a "$logfile")
   exitcode="${PIPESTATUS[0]}"