child_process: fix memory leak in .fork()

Entries in the `net.Server#_workers` array that is used to track handles sent from the master to workers were not deleted when a worker exited, resulting in a slow but inexorable memory leak. PR-URL: nodejs#15679 Fixes: nodejs#15651 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
rachelnicole · Oct 1, 2017 · 2e59ec0 · 2e59ec0
1 parent 3e4f34c
commit 2e59ec0
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/lib/internal/socket_list.js b/lib/internal/socket_list.js
@@ -10,6 +10,7 @@ class SocketListSend extends EventEmitter {
     super();
     this.key = key;
     this.child = child;
+    child.once('exit', () => this.emit('exit', this));
   }
 
   _request(msg, cmd, callback) {

diff --git a/lib/net.js b/lib/net.js
@@ -1665,6 +1665,10 @@ Server.prototype.listenFD = internalUtil.deprecate(function(fd, type) {
 Server.prototype._setupWorker = function(socketList) {
   this._usingWorkers = true;
   this._workers.push(socketList);
+  socketList.once('exit', (socketList) => {
+    const index = this._workers.indexOf(socketList);
+    this._workers.splice(index, 1);
+  });
 };
 
 Server.prototype.ref = function() {

diff --git a/test/parallel/test-child-process-fork-net2.js b/test/parallel/test-child-process-fork-net2.js
@@ -156,6 +156,7 @@ if (process.argv[2] === 'child') {
   }
 
   process.on('exit', function() {
+    assert.strictEqual(server._workers.length, 0);
     assert.strictEqual(disconnected, count);
     assert.strictEqual(connected, count);
   });