Skip to content

Commit

Permalink
fix: live demo failure (pmndrs#1159)
Browse files Browse the repository at this point in the history
* fix: correctly extend THREE for custom canvas

* refactor: remove unnecessary fiber extend
  • Loading branch information
rnike authored Jul 30, 2022
1 parent 0a5f0dc commit a68103b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 1 addition & 5 deletions examples/src/components/Scene.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import * as THREE from 'three'
import { PlaneBufferGeometry } from 'three'
import { useRef, useState } from 'react'
import { Plane, useAspect, useTexture } from '@react-three/drei'
import { useFrame, extend } from '@react-three/fiber'
import { useFrame } from '@react-three/fiber'
import Fireflies from './Fireflies'
import bgUrl from '../resources/bg.jpg'
import starsUrl from '../resources/stars.png'
Expand All @@ -12,9 +11,6 @@ import leaves1Url from '../resources/leaves1.png'
import leaves2Url from '../resources/leaves2.png'
import '../materials/layerMaterial'

// PlaneBufferGeometry is needed for Plane
extend({ PlaneBufferGeometry })

export default function Scene({ dof }) {
const scaleN = useAspect(16, 10, 1.05)
const scaleW = useAspect(22, 10, 1.05)
Expand Down
6 changes: 5 additions & 1 deletion examples/src/index.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import * as THREE from 'three'
import { createRoot } from 'react-dom/client'
import { createRoot as createCanvasRoot, events } from '@react-three/fiber'
import { createRoot as createCanvasRoot, events, extend } from '@react-three/fiber'
import './styles.css'
import App from './App'
import Backdrop from './components/Backdrop'
Expand All @@ -8,6 +9,9 @@ const root = createRoot(document.getElementById('root'))

root.render(<App />)

// https://docs.pmnd.rs/react-three-fiber/api/canvas#custom-canvas
extend(THREE)

const backdrop = createCanvasRoot(document.getElementById('backdrop'))

backdrop
Expand Down

0 comments on commit a68103b

Please sign in to comment.