clib: ssh-agent storage #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjg
previously approved these changes
Aug 20, 2021
alexjg
reviewed
Aug 20, 2021
To allow us to easily add the PublicKey to the ssh-agent in keystore, we need to able to convert to the keystore's version of a PublicKey. Signed-off-by: Fintan Halpenny <[email protected]>
We add the functionality for initialising the storage via the ssh-agent. Signed-off-by: Fintan Halpenny <[email protected]>
There are code paths that require having a Signer, for example needing to set up `transport::Settings`. Since we are already fetching the signer to create the storage we also return it. Signed-off-by: Fintan Halpenny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on radicle-dev/radicle-keystore#21