[Dialog] Make portaled scroll containers scrollable

[joaom00]

Description

As the shards of RemoveScroll are not portal friendly, just moving RemoveScroll to Content solves the problem but this approach has shown to have a problem with OuterScrollable setup, i.e. the scroll event does not bubble up to Overlay if it happens in Content. So to cover this case I opted to render RemoveScroll in both Overlay and Content and enable/disable depending on whether Content is inside Overlay or not.

Fixes #1159

[dogukanoksuz]

When will it be merged?

[sgrund14]

excited for this 😄

[kulgavy]

@benoitgrelard @andy-hook please give a look, we're waiting exited, thanks!

[Rieranthony]

Hey everyone, any news on this? This is also blocking me and my team 👀 Thanks!

[lramos33]

Up

[lukasburns]

Up

[riccardolardi]

Also waiting for this. Is there any workaround for scrolling inside portaled Popover?

[joaom00]

Also waiting for this. Is there any workaround for scrolling inside portaled Popover?

Try wrapper the dialog content with the overlay

<Dialog.Overlay>
  <Dialog.Content>
    ...
  </Dialog.Content>
</Dialog.Overlay>

[riccardolardi]

Also waiting for this. Is there any workaround for scrolling inside portaled Popover?

Try wrapper the dialog content with the overlay

<Dialog.Overlay>
  <Dialog.Content>
    ...
  </Dialog.Content>
</Dialog.Overlay>

Thank you but I'm using the Popover primitive, which does not offer any Overlay. Is there any way to get around it with Popover too?

[joaom00]

Also waiting for this. Is there any workaround for scrolling inside portaled Popover?

Try wrapper the dialog content with the overlay

<Dialog.Overlay>
  <Dialog.Content>
    ...
  </Dialog.Content>
</Dialog.Overlay>

Thank you but I'm using the Popover primitive, which does not offer any Overlay. Is there any way to get around it with Popover too?

Maybe your issue is different. This PR is for a specific issue when used within Dialog. Would you mind opening a ticket and sharing a reproduction example there? Thanks

[tcolinpa]

up 👀

[jgoncalv]

up 👀

[dogukanoksuz]

up

[klingat]

@joaom00 Thank you for you solution, it fixed my exact problem!

Had my overlay like this:

<Ovelay />
<Content>...</Content>

and changing to this made everything still behave the same, but fixes the scroll issue:

<Overlay>
  <Content>...</Content>
<Overlay/>