Bug fix matcher not triggering #2560
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since form input uses the native `change` event, programatically changes doesn't emits. Also if a validationn error has alredy triggers and inout gets updated with same value, validation disappear and form can be submit. Before this fix is happening on custom matcher, and non-custom matcher. issue: radix-ui#2542
| control.dispatchEvent(new Event('change')); | ||
| }; | ||
| control.addEventListener('blur', handleBlur); | ||
| return () => control.removeEventListener('change', handleBlur); |
There was a problem hiding this comment.
Looking at the code, are you sure you want to remove the 'change' event ?
chaance
requested review from
StephenHaney,
lucasmotta,
hadihallak and
chaance
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR intends to fix issue #2542
Why this issue occurs?
Since form input uses the native
changeevent, programmatically updates doesn't emits.Also if a validation error has already triggers and
input.valuegets updated with same value validation disappear, because input event doesn't detect a change hence eventchangenot emits.Currently this is happening for custom and non-custom matchers, i.e.
type="email"inputs.Before
https://github.com/radix-ui/primitives/assets/74157/d2be0df4-403c-491d-bf66-a1bec00e33d7
After
https://github.com/radix-ui/primitives/assets/74157/968d2091-fdd3-492d-b900-986a55707ae1