fix: removes redundent isOpen check in collapsable menu that is preventing users from customizing behaviour #2838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enting users from customizing behaviour
FredrikMWold
requested review from
benoitgrelard,
andy-hook,
vladmoroz and
lucasmotta
as code owners
chaance
requested review from
StephenHaney,
hadihallak and
chaance
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current implementation has both:
hidden={!isOpen}{isOpen && children}Not being able to control how collapsable content is shown, can cause issues when combining it with forms.
If you have form fields inside a collapsable element, the fields can end up not being mounted to the dom when the form is submitted, causing the fields not to be included in
form data.I dont think this is a very common use case so I dont think this needs a custom solution, but allowing the user to control the behaviour by targeting the
data-stateattribute, would be a good middleground.