Improved FileInput Image Preview Rendering #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iew of an image correctly when using byte[] as the TValue instead of string. Added a corresponding demo to highlight this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RadzenFileInput component has support for
byte[]in addition to the default ofstring, however when usingbyte[]the image preview would not display correctly as it would just reference Value directly for the src attribute of the preview img. This would result in something like the following:To address this I have added a new private get only property that will decode the Value if the TValue is of
byte[]. This results in the image preview behaving normally eg:Additionally I have added a corresponding demo to the FileInput Demos to highlight this usage.
Pleases let me know if additional changes are required. I tried to keep things aligned style wise where I could and as this is my first PR on this project any feedback would be appreciated 😄