deprecate none suported network cards

raghavendra-talur · Aug 31, 2020 · a43cde8 · a43cde8
1 parent bdfbf9b
commit a43cde8
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 13 deletions.
diff --git a/frontend/packages/kubevirt-plugin/src/components/modals/nic-modal/nic-modal.tsx b/frontend/packages/kubevirt-plugin/src/components/modals/nic-modal/nic-modal.tsx
@@ -257,15 +257,17 @@ export const NICModal = withHandlePromise((props: NICModalProps) => {
  isDisabled={isDisabled('model') || interfaceType === NetworkInterfaceType.SRIOV}
  >
  <FormSelectPlaceholderOption isDisabled placeholder="--- Select Model ---" />
- {NetworkInterfaceModel.getAll().map((ifaceModel) => {
- return (
- <FormSelectOption
- key={ifaceModel.getValue()}
- value={ifaceModel.getValue()}
- label={ifaceModel.toString()}
- />
- );
- })}
+ {NetworkInterfaceModel.getAll()
+ .filter((ifaceModel) => !ifaceModel.isDeprecated())
+ .map((ifaceModel) => {
+ return (
+ <FormSelectOption
+ key={ifaceModel.getValue()}
+ value={ifaceModel.getValue()}
+ label={ifaceModel.toString()}
+ />
+ );
+ })}
  </FormSelect>
  </FormRow>
  <Network

diff --git a/frontend/packages/kubevirt-plugin/src/constants/vm/network/network-interface-model.ts b/frontend/packages/kubevirt-plugin/src/constants/vm/network/network-interface-model.ts
@@ -4,11 +4,21 @@ import { READABLE_VIRTIO } from '../constants';
 
 export class NetworkInterfaceModel extends ObjectEnum<string> {
  static readonly VIRTIO = new NetworkInterfaceModel('virtio');
- static readonly E1000 = new NetworkInterfaceModel('e1000');
+ static readonly E1000 = new NetworkInterfaceModel('e1000', { isDeprecated: true });
  static readonly E1000E = new NetworkInterfaceModel('e1000e');
- static readonly NE2kPCI = new NetworkInterfaceModel('ne2kPCI');
- static readonly PCNET = new NetworkInterfaceModel('pcnet');
- static readonly RTL8139 = new NetworkInterfaceModel('rtl8139');
+ static readonly NE2kPCI = new NetworkInterfaceModel('ne2kPCI', { isDeprecated: true });
+ static readonly PCNET = new NetworkInterfaceModel('pcnet', { isDeprecated: true });
+ static readonly RTL8139 = new NetworkInterfaceModel('rtl8139', { isDeprecated: true });
+
+ private readonly deprecated: boolean;
+
+ protected constructor(
+ value: string,
+ { isDeprecated = false }: NetworkInterfaceModelConstructorOpts = {},
+ ) {
+ super(value);
+ this.deprecated = isDeprecated;
+ }
 
  private static readonly ALL = Object.freeze(
  ObjectEnum.getAllClassEnumProperties<NetworkInterfaceModel>(NetworkInterfaceModel),
@@ -27,10 +37,16 @@ export class NetworkInterfaceModel extends ObjectEnum<string> {
  static fromString = (model: string): NetworkInterfaceModel =>
  NetworkInterfaceModel.stringMapper[model];
 
+ isDeprecated = () => this.deprecated;
+
  toString() {
  if (this === NetworkInterfaceModel.VIRTIO) {
  return READABLE_VIRTIO;
  }
  return this.value;
  }
 }
+
+type NetworkInterfaceModelConstructorOpts = {
+ isDeprecated?: boolean;
+};