0.30.1 #1
Open
0.30.1 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 28, 2010 23:31
…ulated if a nil didn't exist in a valid credits array.
heimdull
referenced
this pull request
in heimdull/spree_paypal_express
Apr 29, 2011
just pushed a little fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version works with 0.30.1. You DON'T want to pull this into master. Pull it into it's own branch for 0.30.1 since this version will not work in Spree 0.11.x.
NOTE: I have not modified the paypal_express_callbacks_controller.rb so this will not work with 0.30.1. The reason is that I'm not exactly sure how to test any changes to ensure that they are working properly.
Also note: This probably could use a good re-factor, but for now it works so I'm committing it.
Chris