adding basic Dockerfile for packaging #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graphaelli
reviewed
Jan 31, 2018
There was a problem hiding this comment.
considered running as a non-root user with something like https://medium.com/@lizrice/non-privileged-containers-based-on-the-scratch-image-a80105d6d341?
|
|
||
|
|
||
| ## final stage | ||
| FROM alpine:3.7 |
There was a problem hiding this comment.
might as well go FROM scratch at this point?
There was a problem hiding this comment.
@graphaelli Good idea. I will check out the examples and update accordingly.
phriscage
force-pushed
the
docker-build
branch
from
6518c2b to
1e0ecc2
Compare
phriscage
force-pushed
the
docker-build
branch
from
1e0ecc2 to
887cf3d
Compare
chunter0
pushed a commit
to chunter0/hey
that referenced
this pull request
Apr 8, 2024
We were not explicitly testing the behavior of some HTTP verb endpoints like /put and /patch, because they currently share an underlying handler with /post which is thoroughly tested. The addition of the /anything endpoint in rakyll#83 made me realize a bit more explicit test coverage would be good, so here we're landing a bit of a refactoring of the test suite to generate tests for all of those endpoints. Along the way, we also improve compatibility with the original httpbin implementation by tricking the stdlib net/http machinery into parsing request bodies for DELETE requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue/Request:
I added a basic Dockerfile for building/packaging a containerized version of the Hey app. Can be updated/versioned for auto-build and testing later.