Use auto bump functionality in release charts #3365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thardeck
force-pushed
the
use_auto_bump_in_charts_update
branch
from
1c8fb94 to
d3aa8d5
Compare
weyfonk
reviewed
Feb 18, 2025
thardeck
force-pushed
the
use_auto_bump_in_charts_update
branch
5 times, most recently
from
88cccbf to
e372e2f
Compare
thardeck
force-pushed
the
use_auto_bump_in_charts_update
branch
from
e372e2f to
7779cf6
Compare
Github actions by default provides a field for selecting the working branch and this is used for checking out the according branches.
thardeck
force-pushed
the
use_auto_bump_in_charts_update
branch
4 times, most recently
from
75ae6b6 to
94f3858
Compare
auto-merge was automatically disabled
February 21, 2025 10:36
Pull request was converted to draft
thardeck
force-pushed
the
use_auto_bump_in_charts_update
branch
6 times, most recently
from
c92998c to
e416fc9
Compare
because parts of the latest Rancher doe not support kubernetes 1.32 by annotation.
thardeck
force-pushed
the
use_auto_bump_in_charts_update
branch
from
e416fc9 to
fe46617
Compare
weyfonk
approved these changes
Feb 21, 2025
| find ./packages/fleet/ -type f -exec sed -i -e "s/version: ${PREV_CHART_VERSION}/version: ${NEW_CHART_VERSION}/g" {} \; | ||
| if [[ "$(git rev-parse --abbrev-ref HEAD)" =~ dev-v2\.1[0-9]+ ]]; then | ||
| # Use new auto bump scripting until the Github action CI works as expected | ||
| # no parameters besides the target branch are needed in theory, but the pr |
There was a problem hiding this comment.
I'm not sure I understand this comment, as those parameters seem to be very much required 🤔
There was a problem hiding this comment.
As soon as the auto bump works as expected we do not need this script anymore to bump the charts.
I am using the command make chart-bump package=fleet branch="$(git rev-parse --abbrev-ref HEAD)" of the auto bump automation which extracts the latest fleet and chart version on its own, so nothing needs to be provided.
But since there was an issue we rely on our script which still needs these values for creating the pr. It would be possible to extract them too, but not worth it since it should be not needed in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
until the issue is fixed in the charts Github action.
Succesful run
The release charts action will be obsolete as soon as Rancher 2.9 is EOL and the auto bump part works for later Rancher versions as expected.
It does already for Rancher 2.10.