-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use default namespace #211
Merged
Merged
+12
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salasberryfin
requested changes
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a typo
docs/next/modules/en/pages/getting-started/create-first-cluster/using_kubectl.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could make the same changes in the v0.16
docs folder in the same PR (no need to backport in this case), otherwise LGTM
dharmit
reviewed
Feb 3, 2025
docs/next/modules/en/pages/getting-started/create-first-cluster/using_kubectl.adoc
Outdated
Show resolved
Hide resolved
dharmit
reviewed
Feb 3, 2025
docs/next/modules/en/pages/getting-started/create-first-cluster/using_fleet.adoc
Show resolved
Hide resolved
docs/next/modules/en/pages/developer-guide/install_capi_operator.adoc
Outdated
Show resolved
Hide resolved
It is bad practice to use default namespace, due to: - lack of isolation - security risks - resources management - scalability issues
alexander-demicev
approved these changes
Feb 19, 2025
dharmit
approved these changes
Feb 19, 2025
salasberryfin
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is bad practice to use default namespace, due to: