Issue BasicAirData#56 - Workaround to a bug on Android 4.4.X on recreate

rausNT · Jan 26, 2020 · c3eb1e4 · c3eb1e4
1 parent 3233e11
commit c3eb1e4
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 12 deletions.
diff --git a/app/build.gradle b/app/build.gradle
@@ -34,7 +34,7 @@ android {
         minSdkVersion 14
         targetSdkVersion 28
         versionCode 28
-        versionName '2.2.5b_20200122'
+        versionName '2.2.5b_20200126'
     }
     buildTypes {
         debug {

diff --git a/app/src/main/java/eu/basicairdata/graziano/gpslogger/GPSActivity.java b/app/src/main/java/eu/basicairdata/graziano/gpslogger/GPSActivity.java
@@ -87,26 +87,31 @@ public class GPSActivity extends AppCompatActivity {
 
     @Override
     public void onRestart(){
+        Log.w("myApp", "[#] " + this + " - onRestart()");
 
         if (Integer.valueOf(PreferenceManager.getDefaultSharedPreferences(getApplicationContext()).getString("prefColorTheme", "2")) != theme) {
             Log.w("myApp", "[#] GPSActivity.java - it needs to be recreated (Theme changed)");
-            //this.recreate();
-            finish();
-            startActivity(new Intent(this, getClass()));
+            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
+                // Normal behaviour for Android 5 +
+                this.recreate();
+            } else {
+                // Workaround to a bug on Android 4.4.X platform (google won't fix because Android 4.4 is obsolete)
+                // Android 4.4.X: taskAffinity & launchmode='singleTask' violating Activity's lifecycle
+                // https://issuetracker.google.com/issues/36998700
+                finish();
+                startActivity(new Intent(this, getClass()));
+            }
             overridePendingTransition(android.R.anim.fade_in, android.R.anim.fade_out);
         }
         super.onRestart();
-
-        Log.w("myApp", "[#] GPSActivity.java - onRestart()");
     }
 
 
     @Override
     protected void onCreate(Bundle savedInstanceState) {
+        Log.w("myApp", "[#] " + this + " - onCreate()");
 
         setTheme(R.style.MyMaterialTheme);
-        Log.w("myApp", "[#] GPSActivity.java - onCreate()");
-
         theme = Integer.valueOf(PreferenceManager.getDefaultSharedPreferences(getApplicationContext()).getString("prefColorTheme", "2"));
 
         super.onCreate(savedInstanceState);
@@ -147,16 +152,23 @@ public void onTabSelected(TabLayout.Tab tab) {
 
     @Override
     public void onStart() {
+        Log.w("myApp", "[#] " + this + " - onStart()");
         super.onStart();
-
-        //Log.w("myApp", "[#] GPSActivity.java - onStart()");
         activeTab = tabLayout.getSelectedTabPosition();
         GPSApp.setGPSActivity_activeTab(activeTab);
     }
 
 
+    @Override
+    public void onStop() {
+        Log.w("myApp", "[#] " + this + " - onStop()");
+        super.onStop();
+    }
+
+
     @Override
     public void onResume() {
+        Log.w("myApp", "[#] " + this + " - onResume()");
         super.onResume();
 
         // Workaround for Nokia Devices, Android 9
@@ -167,7 +179,6 @@ public void onResume() {
         }
 
         EventBus.getDefault().register(this);
-        Log.w("myApp", "[#] GPSActivity.java - onResume()");
         LoadPreferences();
         EventBus.getDefault().post(EventBusMSG.APP_RESUME);
         if (menutrackfinished != null) menutrackfinished.setVisible(!GPSApp.getCurrentTrack().getName().equals(""));
@@ -226,38 +237,44 @@ public void onClick(DialogInterface dialog, int id) {
         }
     }
 
+
     @Override
     public void onPause() {
+        Log.w("myApp", "[#] " + this + " - onPause()");
         EventBus.getDefault().post(EventBusMSG.APP_PAUSE);
-        Log.w("myApp", "[#] GPSActivity.java - onPause()");
         EventBus.getDefault().unregister(this);
         super.onPause();
     }
 
+
     @Override
     public void onBackPressed() {
         ShutdownApp();
     }
 
+
     @Override
     public void onWindowFocusChanged(boolean hasFocus) {
         super.onWindowFocusChanged(hasFocus);
         updateBottomSheetPosition();
     }
 
+
     @Override
     public boolean onCreateOptionsMenu(Menu menu) {
         getMenuInflater().inflate(R.menu.main_menu, menu);
         return true;
     }
 
+
     @Override
     public boolean onPrepareOptionsMenu(Menu menu) {
         menutrackfinished = menu.findItem(R.id.action_track_finished);
         menutrackfinished.setVisible(!GPSApp.getCurrentTrack().getName().equals(""));
         return true;
     }
 
+
     @Override
     public boolean onOptionsItemSelected(MenuItem item) {
         int id = item.getItemId();