fix(telnet-host/tests): Use existing binaries #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cargo already builds the binary target in the same crate, and exposes its path as a compile-time env var. Use it instead of rebuilding via `escargot`.
That's promising? |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
|
That codecov comment seems wonky |
|
Also, the codecov upload for the commit failed: I don't think we should upload code coverage for commits (as opposed to PRs, which was fine)? |
Hm, yeah, I'll look into fixing that tonight after work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These integration tests are frequently slow. One guess for why is: we (re)build the binaries under test as part of the test (not as part of the build).
This PR eliminates one of the builds always cleanly, and eliminates the other most of the time with a horrible hack (see code comments).