Bug fixes to avoid overflow problems #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @AlyHdr . I'll free up some time to review. First question: do we still need the non-Big implementations of PFCSectionDictionary, SeqLog64, etc? |
|
Yes I think it would be better to keep this in the code base because someone might be using those somewhere, and it still used in some places in the code. |
|
Good point! But for the code itself, we could probably replace them right? |
|
Hmm in theory yes but it should be tested that everything is working properly... |
mielvds
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are adding some bug fixes to use longs and SeqLog64Big in order to avoid overflow problems when dealing with very large files where integers don't suffice anymore.
There is a as well some edge cases when a section is empty and using PFCSectionDictionaryBig class, it throws an exception so we handle this as well.
Some casts to int in resize methods as well are changed to just use long instead to avoid IndexOutOfBoundException when we have an overflow and get a negative value when the arrays are so big.