Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fix (I hope) all the non closed files and mapped buffer in HDT-JAVA-CORE, the main idea is to make it work on Windows, more strict on not closed files.
API Changes
I've added to the
indexedHDT(...)
method athrows IOException
to throw exception instead of a random runtime exception (probably a NPE) in case of error.Old HDTManager.java
New HDTManager.java
Core Changes
Main
close()
andtry-resource
in many methods.IOUtil.cleanBuffer(...)
method andCloseMappedByteBuffer
class to clean byte buffer, this is using the Unsafe due to a JVM exception.IOUtil.mapChannel(...)
method to create mapped file memory to trace mapped memory cleaning (for test)sizeBit mod MAPPING_SIZE = 0
Tests
close()
andtry-resource
in many tests.LongArrayDisk
class.AbstractMapMemoryTest
utility class to test mapped memory allocation.Workflow
.github/workflows/mvn-windows.yaml
file, I can remove it if asked.