Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #59 #60

Closed
wants to merge 1 commit into from
Closed

Fix #59 #60

wants to merge 1 commit into from

Conversation

sharpaper
Copy link

Return null if the .hdt file given in the config file doesn't exist.

Return null if the `.hdt` file given in the config file doesn't exist.
@mielvds
Copy link
Member

mielvds commented Oct 20, 2017

Thanks for the PR! Can you explain why returning null is more helpful than an exception?

@mielvds
Copy link
Member

mielvds commented Oct 20, 2017

After seeing #59, I'm ok with this PR? However, could you adjust the catch clause with a more accurate message?

@sharpaper
Copy link
Author

Thanks for the PR! Can you explain why returning null is more helpful than an exception?

Thread.

The point is that it would be nice to have a flag that allows me to skip those graphs that are defined in the config file but miss the .hdt source, rather than throwing an error. I'm not sure though, what is the best way to handle this... If it should be handled by Fuseki or by hdt-java. I'm closing this PR for now...

@sharpaper sharpaper closed this Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants