Skip to content

feat: support set tree indent width #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 19, 2024

Conversation

lcgash
Copy link
Contributor

@lcgash lcgash commented Jan 31, 2024

支持下自定义树的层级缩进宽度,目前的宽度对我们团队来说有些太宽松了,我们希望能再紧密点。
保持了默认还是 16px 的设定。

Copy link

vercel bot commented Jan 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tree ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 5:48am

@yoyo837
Copy link
Member

yoyo837 commented Feb 1, 2024

需要测试用例

@lcgash
Copy link
Contributor Author

lcgash commented Feb 2, 2024

需要测试用例

辛苦有时间再 review 下

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (762304e) 99.77% compared to head (8a0f816) 99.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #804   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files          14       14           
  Lines        1310     1312    +2     
  Branches      380      382    +2     
=======================================
+ Hits         1307     1309    +2     
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yoyo837
Copy link
Member

yoyo837 commented Feb 2, 2024

需要测试用例

辛苦有时间再 review 下

没有看到用例有covert这个indent

@lcgash
Copy link
Contributor Author

lcgash commented Feb 2, 2024

需要测试用例

辛苦有时间再 review 下

没有看到用例有covert这个indent

辛苦大佬看看这次补充的对了么,之前没搞过这个

@yoyo837 yoyo837 merged commit f367b80 into react-component:master Feb 19, 2024
@zombieJ
Copy link
Member

zombieJ commented May 7, 2024

不对呀,intend 宽度一直是通过 .ant-tree-indent-unit 样式来设置的。不要做 props 透传的

@zombieJ
Copy link
Member

zombieJ commented May 7, 2024

不对呀,intend 宽度一直是通过 .ant-tree-indent-unit 样式来设置的。不要做 props 透传的

&-indent-unit {

改这个,不需要通过 props 传入哈~

@zombieJ zombieJ mentioned this pull request May 7, 2024
@yoyo837
Copy link
Member

yoyo837 commented May 7, 2024

Reverted by #832

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants