Remove unnecessary check in the Sidebar component (vercel#606)

* refactor: remove unneccessary code * refactor: remove excessive function call in modal Co-authored-by: Gonzalo Pozzo <[email protected]>
reactcoder-it · Dec 17, 2021 · 98af5f4 · 98af5f4
1 parent d1f8ff0
commit 98af5f4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 14 deletions.
diff --git a/components/ui/Modal/Modal.tsx b/components/ui/Modal/Modal.tsx
@@ -2,11 +2,8 @@ import { FC, useRef, useEffect, useCallback } from 'react'
 import s from './Modal.module.css'
 import FocusTrap from '@lib/focus-trap'
 import { Cross } from '@components/icons'
-import {
-  disableBodyScroll,
-  clearAllBodyScrollLocks,
-  enableBodyScroll,
-} from 'body-scroll-lock'
+import { disableBodyScroll, clearAllBodyScrollLocks } from 'body-scroll-lock'
+
 interface ModalProps {
   className?: string
   children?: any
@@ -34,9 +31,6 @@ const Modal: FC<ModalProps> = ({ children, onClose }) => {
       window.addEventListener('keydown', handleKey)
     }
     return () => {
-      if (modal) {
-        enableBodyScroll(modal)
-      }
       clearAllBodyScrollLocks()
       window.removeEventListener('keydown', handleKey)
     }

diff --git a/components/ui/Sidebar/Sidebar.tsx b/components/ui/Sidebar/Sidebar.tsx
@@ -1,11 +1,7 @@
 import { FC, useEffect, useRef } from 'react'
 import s from './Sidebar.module.css'
 import cn from 'classnames'
-import {
-  disableBodyScroll,
-  enableBodyScroll,
-  clearAllBodyScrollLocks,
-} from 'body-scroll-lock'
+import { disableBodyScroll, clearAllBodyScrollLocks } from 'body-scroll-lock'
 
 interface SidebarProps {
   children: any
@@ -34,7 +30,6 @@ const Sidebar: FC<SidebarProps> = ({ children, onClose }) => {
     }
 
     return () => {
-      if (contentElement) enableBodyScroll(contentElement)
       clearAllBodyScrollLocks()
     }
   }, [])