Code example mistake in useMemo page #7319
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
ZhenyaGoroh
reviewed
Dec 5, 2024
| @@ -1105,7 +1105,7 @@ function ChatRoom({ roomId }) { | |||
| const connection = createConnection(options); | |||
| connection.connect(); | |||
| return () => connection.disconnect(); | |||
| }, [options]); // ✅ Only changes when createOptions changes | |||
| }, [options]); // ✅ Only changes when create options changes | |||
There was a problem hiding this comment.
Maybe it should be "Only changes when options changes"? What is create options?
There was a problem hiding this comment.
Additionally, line 1104 const options = createOptions(); should be removed.
There was a problem hiding this comment.
Please check #7335
@ZhenyaGoroh @lukahartwig
Thank you all
There was a problem hiding this comment.
Please check #7335 @ZhenyaGoroh @lukahartwig Thank you all
I left the comment. Also I'd suggest to commit changed to this pr instead of creating a new one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.